Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMS-1623 feat: add detail page #20

Merged
merged 15 commits into from
Nov 9, 2023

Conversation

avisiedo
Copy link
Contributor

@avisiedo avisiedo commented Oct 24, 2023

Add the detail view to show a general view and the list of servers that belongs to the selected domain.

The detail view allow to edit the title, description and auto join on launch feature, and delete the current domain.

TODO

  • Vertical align of the labels in the view to the top, into the General tab.
  • Delete operation: delete the record and navigate to the main view; delete from current context application if the record exist in the page.
  • Consistent data propagation when general tab change some data.
  • Server tab: Filter field in servers have to filter the content by the selected column: Addressed at HMS-2999
  • Server tab: Allow to order the table content by Name, Location and HCC Enrollment.

@avisiedo avisiedo self-assigned this Oct 24, 2023
@avisiedo avisiedo marked this pull request as draft October 24, 2023 17:54
@avisiedo avisiedo force-pushed the hms-1623-details-page branch from 7d491d2 to 8801822 Compare October 30, 2023 20:20
@frasertweedale frasertweedale self-requested a review November 6, 2023 06:52
@avisiedo avisiedo force-pushed the hms-1623-details-page branch from df7f956 to 88c8f92 Compare November 7, 2023 01:26
Add manual steps to add /etc/hosts content instead of run a `sudo`
command. Add react tool as a recommended tool.

Signed-off-by: Alejandro Visiedo <[email protected]>
Update the context documentation with the new learnings about how to
build that context, and simplify the code into the `AppEntry.tsx` by
using the `AppContextPovider` defined, making the code cleaner and less
messy.

Signed-off-by: Alejandro Visiedo <[email protected]>
WIP This feature display the details for a given domain.

Signed-off-by: Alejandro Visiedo <[email protected]>
@frasertweedale frasertweedale force-pushed the hms-1623-details-page branch 3 times, most recently from 83b7b4f to 44c7d12 Compare November 8, 2023 08:10
@avisiedo avisiedo marked this pull request as ready for review November 9, 2023 02:24
avisiedo and others added 12 commits November 9, 2023 22:15
This change update the UI changes for the details view for a given
registered domain.

Signed-off-by: Alejandro Visiedo <[email protected]>
Simplify the application context so it is cleaner and easier to add
changes in the future. It adds AppContextProvider tag and refactor
according to it. This new tag assign the setters and the value of the
current states so it is propagated accordingly to the rest of the
application (no more getter callbacks).

Signed-off-by: Alejandro Visiedo <[email protected]>
Implement title ("display name") editing in the detail view.
Editing is via a model dialog with a text box, per the mock-ups.

Pair-Programmed-With: Alejandro Visiedo <[email protected]>
Implement domain description editing in the detail view.  Editing is
via a model dialog with a text area, per the mock-ups.

Pair-Programmed-With: Alejandro Visiedo <[email protected]>
This change adds a composite component to enter the text to filter
for the server tab in the detail view.

We don't use this component (we decided to defer implementing it),
but because this component was already written, we decided to commit
it.  It is available for use at a later time.

Signed-off-by: Alejandro Visiedo <[email protected]>
Clean-up the code for an old intent to display a spinner
while still loading information from the backend service.
Comment the currently not implemented unit tests for DetailGeneral and
DetailServers components.

Signed-off-by: Alejandro Visiedo <[email protected]>
Add some base operations for the context that will be reused along the
application at several points, reducing code duplication. Being specific
it adds the callbacks: updateDomain, deleteDomain and getDomain.

Signed-off-by: Alejandro Visiedo <[email protected]>
Integrate operations with the context, update some components to fit
better with the mocks and add the onChange event to send back the
changes to the parent component.

We additionally replace the TextArea for the description with
`<span>`, whose style respects the white space in the value.

Signed-off-by: Alejandro Visiedo <[email protected]>
Add delete action to the header, send the onChange event to the general
tab component and clean-up the code of the page.

Signed-off-by: Alejandro Visiedo <[email protected]>
Add functionality to order the servers tab content. It was copied from
the implementation at the default page.

Signed-off-by: Alejandro Visiedo <[email protected]>
@frasertweedale
Copy link
Contributor

Pair programmed it with @avisiedo . There are some rough edges but we filed (or will file) follow-up tickets for them. Merging.

@frasertweedale frasertweedale merged commit 7b4abc3 into podengo-project:main Nov 9, 2023
1 check passed
@avisiedo avisiedo deleted the hms-1623-details-page branch April 26, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants